RedisBroker: Leave existing max_concurrency values alone#28
Open
0xDEC0DE wants to merge 1 commit intoNicolasLM:masterfrom
Open
RedisBroker: Leave existing max_concurrency values alone#280xDEC0DE wants to merge 1 commit intoNicolasLM:masterfrom
0xDEC0DE wants to merge 1 commit intoNicolasLM:masterfrom
Conversation
bigjools
requested changes
Nov 28, 2023
Collaborator
bigjools
left a comment
bigjools
left a comment
There was a problem hiding this comment.
I think this is the wrong approach, see my last comment on the ticket.
Leave already-set concurrency values alone, always. Fixes: Issue NicolasLM#27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvalidJobSignatureErrorerrorsFixes: Issue #27